added getRotation() and test #34
Conversation
|
@dorianfm thanks for your contribution. We are currently working on PSR-4-develop branch which will be next major release so I will port this PR to that branch. Master is freezed and we will not be adding anything new at this point. |
|
OK, thanks!
|
|
@dorianfm I have incorporated your PR into the PSR-4-develop branch. Fixed some typos and formatting.... Unfortunately I had to handpick the changes and the trace that you contributed the code will be lost. Are you ok with that, if now what can I do to make it right ? Thank you very much for your contribution. |
|
thanks @char0n, happy for it to be incorporated in any way, the availability of the functionality is much more important than any trace that I did it. |
|
@dorianfm ok cool. We have now new and shiny PSR-4 compatible codebase ready with full composer support. The only thing blocking the new release now are some infrastructure issues and writing a new documentation. Thanks again. |
I've added an FFmpegMovie->getRotation() method and test to return the rotation, or 0, of the movie file. This is particularly useful when dealing with movies that have been recorded portrait on mobile phones and where the width and height parameters should be transposed for presentation.
I've not changed the values returned from getFrameWidth() and getFrameHeight() when the getRotation() values is 90 or -90, though this should possible be discussed in future, it would be a breaking change to the API.